Skip to content

[log] Add debug logging to unlogged branches in cli package-manifest/actionlint code - #72299

Merged
pelikhan merged 1 commit into
mainfrom
log/cli-package-manifest-actionlint-gaps-f7d4cf35f98946c1
Oct 27, 2026
Merged

pelikhan merged 1 commit into
mainfrom
log/cli-package-manifest-actionlint-gaps-f7d4cf35f98946c1

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Summary

The deterministic candidate manifest this run started from (files_needing_logger, first 38 entries) turned out to be stale: the pkg/actionpins and pkg/agentdrain packages it listed first are already extensively instrumented with loggers at nearly every candidate line, and several other candidates (pkg/actionpins/types.go, pkg/agentdrain/config.go, pkg/agentdrain/types.go, pkg/cli/add_package_manifest.go) are pure type/constant definitions with no branching logic worth logging. Adding more calls there would have been duplicate or trivial logging.

Instead I looked for files that already declare a logger but still have many unlogged functions, i.e. real coverage gaps. Five pkg/cli files stood out:

  • actionlint.go (31 funcs / 11 existing logs): logged actionlint subprocess completion, timeout/cancellation detection, and the findings-vs-no-findings reporting branch.
  • add_package_manifest_includes.go (29 funcs / 7 existing logs): logged path-traversal/absolute-path rejection and wildcard expansion match counts.
  • add_package_manifest_remote.go (15 funcs / 7 existing logs): logged package-path traversal rejection and which ref source was chosen.
  • add_package_manifest_parse.go (21 funcs / 11 existing logs): logged the description-length-exceeded warning and icon-validation rejection branches.
  • add_interactive_orchestrator.go (17 funcs / 10 existing logs): resolveWorkflows and determineFilesToAdd previously logged only the start of the operation, not the outcome; added logs for resolved/determined counts.

All 17 new log statements use the existing per-file logger variable, follow the pkg:filename namespace convention already established, and avoid side-effecting arguments.

Validation

  • make build - passes
  • make fmt - passes

Note on the candidate manifest

The pre-flight manifest.json used to seed this run appears generated from a stale snapshot relative to pkg/actionpins and pkg/agentdrain, which are already fully logged in the current tree. Regenerating that backlog would avoid future runs re-surfacing already-saturated files.

Generated by 📝 Go Logger Enhancement · claude · agent · ~120 AIC · ⌖ ~1 AIC · ⊞ 4.2K · ◷

  • expires on Oct 28, 2026, 7:39 PM UTC-08:00

…ctionlint code

These files already had a logger declared but several branchy functions
(wildcard expansion, path traversal rejection, icon validation, timeout/
cancel handling, result reporting) had zero log calls, leaving silent gaps
in otherwise well-instrumented code.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions github-actions Bot added automation enhancement New feature or request labels Oct 27, 2026
@pelikhan
pelikhan merged commit ff1df1b into main Oct 27, 2026
2 checks passed
@pelikhan
pelikhan deleted the log/cli-package-manifest-actionlint-gaps-f7d4cf35f98946c1 branch October 27, 2026 09:06
@github-actions

Copy link
Copy Markdown
Contributor Author

🎉 This pull request is included in a new release.

Release: v1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant